Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for zeromq connection bug #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coolaj86
Copy link

@coolaj86
Copy link
Author

coolaj86 commented Jun 20, 2023

Note: calling process.exit(1) since there is no errback to properly handle errors and this is a fatal error that would make the instance completely unusable - at least for the use cases I'm aware of (not sure how having an API service that can only return errors is helpful).

Choosing 5 seconds because a valid network connection would have TCP rejected, TCP accepted or 'no-route-to-host'ed by then.

Only an invalid address or a firewall DROP should cause this.

@coolaj86 coolaj86 force-pushed the fix-zeromq-silent-errors branch from 5d07a3d to a01e2b7 Compare June 20, 2023 08:33
@coolaj86 coolaj86 force-pushed the fix-zeromq-silent-errors branch from a01e2b7 to 43adeed Compare June 20, 2023 08:36
lib/services/dashd.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants